Skip to content

Commit 40fbc59

Browse files
Jakub197mattrope
authored andcommitted
drm/xe/vf: Don't check has flat ccs in bios on VF
Don't check for flat ccs from VF-level as VF does not have direct access to the register. If the BIOS disables FlatCCS support (a use-case that will nearly never be used) and the has_flat_ccs flag is set, there shouldn't be any functional impact. The hardware will drop writes to the CCS region, and reads from the CCS region will always return 0. For the native case, the flag is disabled if the BIOS disables it to avoid unnecessary overhead in buffer object (BO) creation and migration. Signed-off-by: Jakub Kolakowski <[email protected]> Suggested-by: Piotr Piórkowski <[email protected]> Cc: Adam Miszczak <[email protected]> Cc: Jakub Kolakowski <[email protected]> Cc: Lukasz Laguna <[email protected]> Cc: Marcin Bernatowicz <[email protected]> Cc: Michal Wajdeczko <[email protected]> Cc: Michal Winiarski <[email protected]> Cc: Narasimha C V <[email protected]> Cc: Piotr Piorkowski <[email protected]> Cc: Satyanarayana K V P <[email protected]> Cc: Tomasz Lis <[email protected]> Cc: Matt Roper <[email protected]> Signed-off-by: Marcin Bernatowicz <[email protected]> Reviewed-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Matt Roper <[email protected]>
1 parent 6acea03 commit 40fbc59

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/xe/xe_device.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ static int probe_has_flat_ccs(struct xe_device *xe)
607607
u32 reg;
608608

609609
/* Always enabled/disabled, no runtime check to do */
610-
if (GRAPHICS_VER(xe) < 20 || !xe->info.has_flat_ccs)
610+
if (GRAPHICS_VER(xe) < 20 || !xe->info.has_flat_ccs || IS_SRIOV_VF(xe))
611611
return 0;
612612

613613
gt = xe_root_mmio_gt(xe);

0 commit comments

Comments
 (0)