Skip to content

Commit 410612b

Browse files
sprasad-microsoftsmfrench
authored andcommitted
cifs: reuse cifs_match_ipaddr for comparison of dstaddr too
We have two pieces of code that does pretty much the same comparison. This change reuses cifs_match_ipaddr within match_address. Signed-off-by: Shyam Prasad N <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent a21be1f commit 410612b

File tree

1 file changed

+2
-26
lines changed

1 file changed

+2
-26
lines changed

fs/cifs/connect.c

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,32 +1344,8 @@ match_port(struct TCP_Server_Info *server, struct sockaddr *addr)
13441344

13451345
static bool match_server_address(struct TCP_Server_Info *server, struct sockaddr *addr)
13461346
{
1347-
switch (addr->sa_family) {
1348-
case AF_INET: {
1349-
struct sockaddr_in *addr4 = (struct sockaddr_in *)addr;
1350-
struct sockaddr_in *srv_addr4 =
1351-
(struct sockaddr_in *)&server->dstaddr;
1352-
1353-
if (addr4->sin_addr.s_addr != srv_addr4->sin_addr.s_addr)
1354-
return false;
1355-
break;
1356-
}
1357-
case AF_INET6: {
1358-
struct sockaddr_in6 *addr6 = (struct sockaddr_in6 *)addr;
1359-
struct sockaddr_in6 *srv_addr6 =
1360-
(struct sockaddr_in6 *)&server->dstaddr;
1361-
1362-
if (!ipv6_addr_equal(&addr6->sin6_addr,
1363-
&srv_addr6->sin6_addr))
1364-
return false;
1365-
if (addr6->sin6_scope_id != srv_addr6->sin6_scope_id)
1366-
return false;
1367-
break;
1368-
}
1369-
default:
1370-
WARN_ON(1);
1371-
return false; /* don't expect to be here */
1372-
}
1347+
if (!cifs_match_ipaddr(addr, (struct sockaddr *)&server->dstaddr))
1348+
return false;
13731349

13741350
return true;
13751351
}

0 commit comments

Comments
 (0)