Skip to content

Commit 4175266

Browse files
bmodemManasi Navare
authored andcommitted
drm/debug: Expose connector VRR monitor range via debugfs
[Why] It's useful to know the min and max vrr range for IGT testing. [How] Expose the min and max vfreq for the connector via a debugfs file on the connector, "vrr_range". Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range v2: * Fix the typo in max_vfreq (Manasi) * Change the name of node to i915_vrr_info so we can add other vrr info for more debug info (Manasi) * Change the VRR capable to display Yes or No (Manasi) * Fix indentation checkpatch errors (Manasi) v3: * Remove the unnecessary debug print (Manasi) v4: * Rebase v5: * Rename to vrr_range to match AMD debugfs v6: * Rebase (manasi) v7: * Fix cmpilation due to rebase v8: * Move debugfs node creation logic to DRM (Emil) * Remove AMD specific logic (Emil) v9: * Separate patch for removal of AMD specific logic (Manasi) Signed-off-by: Bhanuprakash Modem <[email protected]> Signed-off-by: Manasi Navare <[email protected]> Cc: Jani Nikula <[email protected]> Cc: Ville Syrjälä <[email protected]> Cc: Harry Wentland <[email protected]> CC: Emil Velikov <[email protected]> Reviewed-by: Manasi Navare <[email protected]> Signed-off-by: Manasi Navare <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 6b86a12 commit 4175266

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

drivers/gpu/drm/drm_debugfs.c

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,24 @@ static ssize_t edid_write(struct file *file, const char __user *ubuf,
376376
return (ret) ? ret : len;
377377
}
378378

379+
/*
380+
* Returns the min and max vrr vfreq through the connector's debugfs file.
381+
* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range
382+
*/
383+
static int vrr_range_show(struct seq_file *m, void *data)
384+
{
385+
struct drm_connector *connector = m->private;
386+
387+
if (connector->status != connector_status_connected)
388+
return -ENODEV;
389+
390+
seq_printf(m, "Min: %u\n", (u8)connector->display_info.monitor_range.min_vfreq);
391+
seq_printf(m, "Max: %u\n", (u8)connector->display_info.monitor_range.max_vfreq);
392+
393+
return 0;
394+
}
395+
DEFINE_SHOW_ATTRIBUTE(vrr_range);
396+
379397
static const struct file_operations drm_edid_fops = {
380398
.owner = THIS_MODULE,
381399
.open = edid_open,
@@ -413,6 +431,10 @@ void drm_debugfs_connector_add(struct drm_connector *connector)
413431
/* edid */
414432
debugfs_create_file("edid_override", S_IRUGO | S_IWUSR, root, connector,
415433
&drm_edid_fops);
434+
435+
/* vrr range */
436+
debugfs_create_file("vrr_range", S_IRUGO, root, connector,
437+
&vrr_range_fops);
416438
}
417439

418440
void drm_debugfs_connector_remove(struct drm_connector *connector)

0 commit comments

Comments
 (0)