Skip to content

Commit 4190156

Browse files
Matthew Wilcox (Oracle)torvalds
authored andcommitted
mm: move page-flags include to top of file
Give up on the notion that we can remove page-flags.h from mm.h. There are currently 14 inline functions which use a PageFoo function. Also, two of the files directly included by mm.h include page-flags.h themselves, and there are probably more indirect inclusions. So just include it at the top like any other header file. Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Reviewed-by: William Kucharski <[email protected]> Reviewed-by: Zi Yan <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: Mike Kravetz <[email protected]> Cc: "Kirill A. Shutemov" <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Linus Torvalds <[email protected]>
1 parent 1378a5e commit 4190156

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

include/linux/mm.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#include <linux/resource.h>
2525
#include <linux/page_ext.h>
2626
#include <linux/err.h>
27+
#include <linux/page-flags.h>
2728
#include <linux/page_ref.h>
2829
#include <linux/memremap.h>
2930
#include <linux/overflow.h>
@@ -668,11 +669,6 @@ int vma_is_stack_for_current(struct vm_area_struct *vma);
668669
struct mmu_gather;
669670
struct inode;
670671

671-
/*
672-
* FIXME: take this include out, include page-flags.h in
673-
* files which need it (119 of them)
674-
*/
675-
#include <linux/page-flags.h>
676672
#include <linux/huge_mm.h>
677673

678674
/*

0 commit comments

Comments
 (0)