Skip to content

Commit 41b02ea

Browse files
matttbekuba-moo
authored andcommitted
selftests: net: lib: support errexit with busywait
If errexit is enabled ('set -e'), loopy_wait -- or busywait and others using it -- will stop after the first failure. Note that if the returned status of loopy_wait is checked, and even if errexit is enabled, Bash will not stop at the first error. Fixes: 25ae948 ("selftests/net: add lib.sh") Cc: [email protected] Acked-by: Geliang Tang <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Reviewed-by: Hangbin Liu <[email protected]> Link: https://lore.kernel.org/r/20240605-upstream-net-20240605-selftests-net-lib-fixes-v1-1-b3afadd368c9@kernel.org Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 0dcc53a commit 41b02ea

File tree

1 file changed

+1
-3
lines changed
  • tools/testing/selftests/net

1 file changed

+1
-3
lines changed

tools/testing/selftests/net/lib.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@ loopy_wait()
6767
while true
6868
do
6969
local out
70-
out=$("$@")
71-
local ret=$?
72-
if ((!ret)); then
70+
if out=$("$@"); then
7371
echo -n "$out"
7472
return 0
7573
fi

0 commit comments

Comments
 (0)