mtd: spi-nor: Fix direction of the write_sr() transfer

ambarus · miquelraynal · commit 41e086e15506 · 2019-10-04T18:09:01.000+02:00
write_sr() sends data to the SPI memory, fix the direction. Fixes: b35b9a1 ("mtd: spi-nor: Move m25p80 code in spi-nor.c") Reported-by: John Garry <john.garry@huawei.com> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Tested-by: John Garry <john.garry@huawei.com> Acked-by: Vignesh Raghavendra <vigneshr@ti.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
@@ -487,7 +487,7 @@ static int write_sr(struct spi_nor *nor, u8 val)
 			SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WRSR, 1),
 				   SPI_MEM_OP_NO_ADDR,
 				   SPI_MEM_OP_NO_DUMMY,
-				   SPI_MEM_OP_DATA_IN(1, nor->bouncebuf, 1));
+				   SPI_MEM_OP_DATA_OUT(1, nor->bouncebuf, 1));
 
 		return spi_mem_exec_op(nor->spimem, &op);
 	}

Original file line number	Diff line number	Diff line change
`@@ -487,7 +487,7 @@ static int write_sr(struct spi_nor *nor, u8 val)`
`487`	`487`	`SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WRSR, 1),`
`488`	`488`	`SPI_MEM_OP_NO_ADDR,`
`489`	`489`	`SPI_MEM_OP_NO_DUMMY,`
`490`		`- SPI_MEM_OP_DATA_IN(1, nor->bouncebuf, 1));`
	`490`	`+ SPI_MEM_OP_DATA_OUT(1, nor->bouncebuf, 1));`
`491`	`491`
`492`	`492`	`return spi_mem_exec_op(nor->spimem, &op);`
`493`	`493`	`}`