Skip to content

Commit 41f1242

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_ec_proto: update Kunit test for get_next_data_v3
Since commit 106d673 ("platform/chrome: cros_ec_proto: Upgrade get_next_event to v3"), (struct cros_ec_device *)->event_data becomes struct ec_response_get_next_event_v3. Update the Kunit test for fixing the following error: > Expected mock->msg.insize == sizeof(union ec_response_get_next_data_v1), but > mock->msg.insize == 18 (0x12) > sizeof(union ec_response_get_next_data_v1) == 16 (0x10) Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tzung-Bi Shih <[email protected]>
1 parent d11c002 commit 41f1242

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/platform/chrome/cros_ec_proto_test.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2060,17 +2060,17 @@ static void cros_ec_proto_test_get_next_event_no_mkbp_event(struct kunit *test)
20602060

20612061
/* For get_keyboard_state_event(). */
20622062
{
2063-
union ec_response_get_next_data_v1 *data;
2063+
union ec_response_get_next_data_v3 *data;
20642064

20652065
mock = cros_kunit_ec_xfer_mock_add(test, sizeof(*data));
20662066
KUNIT_ASSERT_PTR_NE(test, mock, NULL);
20672067

2068-
data = (union ec_response_get_next_data_v1 *)mock->o_data;
2068+
data = (union ec_response_get_next_data_v3 *)mock->o_data;
20692069
data->host_event = 0xbeef;
20702070
}
20712071

20722072
ret = cros_ec_get_next_event(ec_dev, &wake_event, &more_events);
2073-
KUNIT_EXPECT_EQ(test, ret, sizeof(union ec_response_get_next_data_v1));
2073+
KUNIT_EXPECT_EQ(test, ret, sizeof(union ec_response_get_next_data_v3));
20742074

20752075
KUNIT_EXPECT_EQ(test, ec_dev->event_data.event_type, EC_MKBP_EVENT_KEY_MATRIX);
20762076
KUNIT_EXPECT_EQ(test, ec_dev->event_data.data.host_event, 0xbeef);
@@ -2085,7 +2085,7 @@ static void cros_ec_proto_test_get_next_event_no_mkbp_event(struct kunit *test)
20852085

20862086
KUNIT_EXPECT_EQ(test, mock->msg.version, 0);
20872087
KUNIT_EXPECT_EQ(test, mock->msg.command, EC_CMD_MKBP_STATE);
2088-
KUNIT_EXPECT_EQ(test, mock->msg.insize, sizeof(union ec_response_get_next_data_v1));
2088+
KUNIT_EXPECT_EQ(test, mock->msg.insize, sizeof(union ec_response_get_next_data_v3));
20892089
KUNIT_EXPECT_EQ(test, mock->msg.outsize, 0);
20902090
}
20912091
}

0 commit comments

Comments
 (0)