Skip to content

Commit 4210ef8

Browse files
andy-shevlinusw
authored andcommitted
pinctrl: aw9523: Get rid of redundant ' & U8_MAX' pieces
When the variable is declared as u8, no need to perform ' & U8_MAX' as it's implied anyway. Signed-off-by: Andy Shevchenko <[email protected]> Message-ID: <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 66413f0 commit 4210ef8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/pinctrl/pinctrl-aw9523.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ static int aw9523_gpio_get_multiple(struct gpio_chip *chip,
603603
mutex_lock(&awi->i2c_lock);
604604

605605
/* Port 0 (gpio 0-7) */
606-
m = *mask & U8_MAX;
606+
m = *mask;
607607
if (m) {
608608
ret = _aw9523_gpio_get_multiple(awi, 0, &state, m);
609609
if (ret)
@@ -612,7 +612,7 @@ static int aw9523_gpio_get_multiple(struct gpio_chip *chip,
612612
*bits = state;
613613

614614
/* Port 1 (gpio 8-15) */
615-
m = (*mask >> 8) & U8_MAX;
615+
m = *mask >> 8;
616616
if (m) {
617617
ret = _aw9523_gpio_get_multiple(awi, AW9523_PINS_PER_PORT,
618618
&state, m);
@@ -635,20 +635,20 @@ static void aw9523_gpio_set_multiple(struct gpio_chip *chip,
635635
unsigned int reg;
636636
int ret;
637637

638-
mask_lo = *mask & U8_MAX;
639-
mask_hi = (*mask >> 8) & U8_MAX;
638+
mask_lo = *mask;
639+
mask_hi = *mask >> 8;
640+
bits_lo = *bits;
641+
bits_hi = *bits >> 8;
642+
640643
mutex_lock(&awi->i2c_lock);
641644
if (mask_hi) {
642645
reg = AW9523_REG_OUT_STATE(AW9523_PINS_PER_PORT);
643-
bits_hi = (*bits >> 8) & U8_MAX;
644-
645646
ret = regmap_write_bits(awi->regmap, reg, mask_hi, bits_hi);
646647
if (ret)
647648
dev_warn(awi->dev, "Cannot write port1 out level\n");
648649
}
649650
if (mask_lo) {
650651
reg = AW9523_REG_OUT_STATE(0);
651-
bits_lo = *bits & U8_MAX;
652652
ret = regmap_write_bits(awi->regmap, reg, mask_lo, bits_lo);
653653
if (ret)
654654
dev_warn(awi->dev, "Cannot write port0 out level\n");

0 commit comments

Comments
 (0)