Skip to content

Commit 4229dd0

Browse files
committed
drm/i915/dsi: add VLV_ prefix to VLV only register macros
All the BXT specific macros have BXT_ prefix, do the same for VLV for consistency. This is helpful because the platform specific macros can use the static MIPI MMIO base rather than dynamic. Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/7e101167c52746748dbff739bc9247a664ca2840.1713520813.git.jani.nikula@intel.com Signed-off-by: Jani Nikula <[email protected]>
1 parent 34ef188 commit 4229dd0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

drivers/gpu/drm/i915/display/vlv_dsi.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ static void vlv_dsi_device_ready(struct intel_encoder *encoder)
481481
* Common bit for both MIPI Port A & MIPI Port C
482482
* No similar bit in MIPI Port C reg
483483
*/
484-
intel_de_rmw(dev_priv, MIPI_PORT_CTRL(PORT_A), 0, LP_OUTPUT_HOLD);
484+
intel_de_rmw(dev_priv, VLV_MIPI_PORT_CTRL(PORT_A), 0, LP_OUTPUT_HOLD);
485485
usleep_range(1000, 1500);
486486

487487
intel_de_write(dev_priv, MIPI_DEVICE_READY(port),
@@ -563,7 +563,7 @@ static void glk_dsi_clear_device_ready(struct intel_encoder *encoder)
563563
static i915_reg_t port_ctrl_reg(struct drm_i915_private *i915, enum port port)
564564
{
565565
return IS_GEMINILAKE(i915) || IS_BROXTON(i915) ?
566-
BXT_MIPI_PORT_CTRL(port) : MIPI_PORT_CTRL(port);
566+
BXT_MIPI_PORT_CTRL(port) : VLV_MIPI_PORT_CTRL(port);
567567
}
568568

569569
static void vlv_dsi_clear_device_ready(struct intel_encoder *encoder)
@@ -576,7 +576,7 @@ static void vlv_dsi_clear_device_ready(struct intel_encoder *encoder)
576576
for_each_dsi_port(port, intel_dsi->ports) {
577577
/* Common bit for both MIPI Port A & MIPI Port C on VLV/CHV */
578578
i915_reg_t port_ctrl = IS_BROXTON(dev_priv) ?
579-
BXT_MIPI_PORT_CTRL(port) : MIPI_PORT_CTRL(PORT_A);
579+
BXT_MIPI_PORT_CTRL(port) : VLV_MIPI_PORT_CTRL(PORT_A);
580580

581581
intel_de_write(dev_priv, MIPI_DEVICE_READY(port),
582582
DEVICE_READY | ULPS_STATE_ENTER);

drivers/gpu/drm/i915/display/vlv_dsi_regs.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
#define _MIPIA_PORT_CTRL (VLV_DISPLAY_BASE + 0x61190)
4242
#define _MIPIC_PORT_CTRL (VLV_DISPLAY_BASE + 0x61700)
43-
#define MIPI_PORT_CTRL(port) _MMIO_MIPI(port, _MIPIA_PORT_CTRL, _MIPIC_PORT_CTRL)
43+
#define VLV_MIPI_PORT_CTRL(port) _MMIO_MIPI(port, _MIPIA_PORT_CTRL, _MIPIC_PORT_CTRL)
4444

4545
/* BXT port control */
4646
#define _BXT_MIPIA_PORT_CTRL 0x6B0C0
@@ -89,7 +89,7 @@
8989

9090
#define _MIPIA_TEARING_CTRL (VLV_DISPLAY_BASE + 0x61194)
9191
#define _MIPIC_TEARING_CTRL (VLV_DISPLAY_BASE + 0x61704)
92-
#define MIPI_TEARING_CTRL(port) _MMIO_MIPI(port, _MIPIA_TEARING_CTRL, _MIPIC_TEARING_CTRL)
92+
#define VLV_MIPI_TEARING_CTRL(port) _MMIO_MIPI(port, _MIPIA_TEARING_CTRL, _MIPIC_TEARING_CTRL)
9393
#define TEARING_EFFECT_DELAY_SHIFT 0
9494
#define TEARING_EFFECT_DELAY_MASK (0xffff << 0)
9595

0 commit comments

Comments
 (0)