Skip to content

Commit 4248d04

Browse files
committed
Revert "ARM: mach-virt: Select PMUv3 driver by default"
This reverts commit 3b16f62. Selecting a Kconfig option that has its own set of dependencies tends to end badly, and in this case 'randconfig' builds blew up on 32-bit ARM where ARM_PMUV3 was being selecting with HW_PERF_EVENTS=n: | drivers/perf/arm_pmuv3.c:68:5: error: use of undeclared identifier 'DTLB' | [C(DTLB)][C(OP_READ)][C(RESULT_ACCESS)] = ARMV8_PMUV3_PERFCTR_L1D_TLB, | ^ | fatal error: too many errors emitted, stopping now [-ferror-limit=] | 20 errors generated. | | Kconfig warnings: (for reference only) | WARNING: unmet direct dependencies detected for ARM_PMUV3 | Depends on [n]: PERF_EVENTS [=y] && HW_PERF_EVENTS [=n] && (ARM [=y] && CPU_V7 [=y] || ARM64) | Selected by [y]: | - ARCH_VIRT [=y] && ARCH_MULTI_V7 [=y] && PERF_EVENTS [=y] As suggested by Marc, just drop the 'select' clause altogether by reverting the patch which introduced it. Link: https://lore.kernel.org/r/[email protected] Reported-by: kernel test robot <[email protected]> Reported-by: Arnd Bergmann <[email protected]> Suggested-by: Marc Zyngier <[email protected]> Signed-off-by: Will Deacon <[email protected]>
1 parent 7d0bfb7 commit 4248d04

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/arm/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,6 @@ config ARCH_VIRT
401401
select ARM_GIC_V3
402402
select ARM_GIC_V3_ITS if PCI
403403
select ARM_PSCI
404-
select ARM_PMUV3 if PERF_EVENTS
405404
select HAVE_ARM_ARCH_TIMER
406405

407406
config ARCH_AIROHA

0 commit comments

Comments
 (0)