Skip to content

Commit 42aa18d

Browse files
committed
drm/vc4: Correct generation check in vc4_hvs_lut_load
Commit 24c5ed3 ("drm/vc4: Introduce generation number enum") incorrectly swapped a check of hvs->vc4->is_vc5 to hvs->vc4->gen == VC4_GEN_4 in vc4_hvs_lut_load, hence breaking loading the gamma look up table on Pi0-3. Correct that conditional. Fixes: 24c5ed3 ("drm/vc4: Introduce generation number enum") Reported-by: Marek Szyprowski <[email protected]> Closes: https://lore.kernel.org/dri-devel/[email protected]/ Tested-by: Marek Szyprowski <[email protected]> Reviewed-by: Maíra Canal <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Dave Stevenson <[email protected]>
1 parent 6b0bd1b commit 42aa18d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/vc4/vc4_hvs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ static void vc4_hvs_lut_load(struct vc4_hvs *hvs,
224224
if (!drm_dev_enter(drm, &idx))
225225
return;
226226

227-
if (hvs->vc4->gen == VC4_GEN_4)
227+
if (hvs->vc4->gen != VC4_GEN_4)
228228
goto exit;
229229

230230
/* The LUT memory is laid out with each HVS channel in order,

0 commit comments

Comments
 (0)