ceph: request new max size only when there is auth cap

ukernel · idryomov · commit 42d70f8e31df · 2020-03-30T12:42:43.000+02:00
When there is no auth cap, check_max_size() can't do anything and may
cause an infinite loop inside ceph_get_caps().

Signed-off-by: "Yan, Zheng" &lt;zyan@redhat.com&gt;
Reviewed-by: Jeff Layton &lt;jlayton@kernel.org&gt;
Signed-off-by: Ilya Dryomov &lt;idryomov@gmail.com&gt;
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
@@ -2582,7 +2582,7 @@ static int try_get_cap_refs(struct inode *inode, int need, int want,
 			dout("get_cap_refs %p endoff %llu > maxsize %llu\n",
 			     inode, endoff, ci->i_max_size);
 			if (endoff > ci->i_requested_max_size)
-				ret = -EFBIG;
+				ret = ci->i_auth_cap ? -EFBIG : -ESTALE;
 			goto out_unlock;
 		}
 		/*

Original file line number	Diff line number	Diff line change
`@@ -2582,7 +2582,7 @@ static int try_get_cap_refs(struct inode *inode, int need, int want,`
`2582`	`2582`	`dout("get_cap_refs %p endoff %llu > maxsize %llu\n",`
`2583`	`2583`	`inode, endoff, ci->i_max_size);`
`2584`	`2584`	`if (endoff > ci->i_requested_max_size)`
`2585`		`- ret = -EFBIG;`
	`2585`	`+ ret = ci->i_auth_cap ? -EFBIG : -ESTALE;`
`2586`	`2586`	`goto out_unlock;`
`2587`	`2587`	`}`
`2588`	`2588`	`/*`