Skip to content

Commit 432dd1f

Browse files
M-Vaittinenbroonie
authored andcommitted
regulator: rohm-generic: remove unused dummies
Function rohm_regulator_set_voltage_sel_restricted() and rohm_regulator_set_dvs_levels() had inlined dummy implementations for cases when the real implementation was not configured in. All of the drivers who issue the call to these functions do SELECT the real implementation from the Kconfig. There should be no cases where the real implementation was not selected by the drivers using these functions - such a situation is likely to be an error which deserves to be noticed at compile-time. These dummies could in theory be used for compile-testing the drivers only (without the generic rohm regulator pieces). However, for such compile testing we should manually drop the selection from KConfig - and I guess that if it does not work out-of-the-box, then it is not going to happen. Especially when there should be no reason to omit compile-testing the generic rohm_regulator part. Crash test dummies. Signed-off-by: Matti Vaittinen <[email protected]> Link: https://lore.kernel.org/r/YZ3UXXrk/Efe7Scj@fedora Signed-off-by: Mark Brown <[email protected]>
1 parent a764ff7 commit 432dd1f

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

include/linux/mfd/rohm-generic.h

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82,20 +82,6 @@ int rohm_regulator_set_dvs_levels(const struct rohm_dvs_config *dvs,
8282

8383
int rohm_regulator_set_voltage_sel_restricted(struct regulator_dev *rdev,
8484
unsigned int sel);
85-
#else
86-
static inline int rohm_regulator_set_dvs_levels(const struct rohm_dvs_config *dvs,
87-
struct device_node *np,
88-
const struct regulator_desc *desc,
89-
struct regmap *regmap)
90-
{
91-
return 0;
92-
}
93-
94-
static inline int rohm_regulator_set_voltage_sel_restricted(struct regulator_dev *rdev,
95-
unsigned int sel)
96-
{
97-
return 0;
98-
}
9985
#endif
10086

10187
#endif

0 commit comments

Comments
 (0)