Skip to content

Commit 437ad45

Browse files
jnar17johnharr-intel
authored andcommitted
drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI
This warning was supposed to catch a harmless issue, but changing to guc_error should prevent kernel taints in CI runs. Signed-off-by: Jesus Narvaez <[email protected]> Reviewed-by: Jonathan Cavitt <[email protected]> Signed-off-by: John Harrison <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a857add commit 437ad45

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2014,11 +2014,12 @@ void intel_guc_submission_reset_finish(struct intel_guc *guc)
20142014

20152015
/*
20162016
* Technically possible for either of these values to be non-zero here,
2017-
* but very unlikely + harmless. Regardless let's add a warn so we can
2017+
* but very unlikely + harmless. Regardless let's add an error so we can
20182018
* see in CI if this happens frequently / a precursor to taking down the
20192019
* machine.
20202020
*/
2021-
GEM_WARN_ON(atomic_read(&guc->outstanding_submission_g2h));
2021+
if (atomic_read(&guc->outstanding_submission_g2h))
2022+
guc_err(guc, "Unexpected outstanding GuC to Host in reset finish\n");
20222023
atomic_set(&guc->outstanding_submission_g2h, 0);
20232024

20242025
intel_guc_global_policies_update(guc);

0 commit comments

Comments
 (0)