pwm: meson: Remove redundant assignment to variable fin_freq

Colin Ian King · thierryreding · commit 437fb760d046 · 2020-04-03T21:40:56.000+02:00
The variable fin_freq is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Acked-by: Uwe Kleine-König &lt;u.kleine-koenig@pengutronix.de&gt;
Signed-off-by: Thierry Reding &lt;thierry.reding@gmail.com&gt;
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
@@ -163,7 +163,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm,
 {
 	struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);
 	unsigned int duty, period, pre_div, cnt, duty_cnt;
-	unsigned long fin_freq = -1;
+	unsigned long fin_freq;
 
 	duty = state->duty_cycle;
 	period = state->period;

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ static int meson_pwm_calc(struct meson_pwm meson, struct pwm_device pwm,`
`163`	`163`	`{`
`164`	`164`	`struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);`
`165`	`165`	`unsigned int duty, period, pre_div, cnt, duty_cnt;`
`166`		`- unsigned long fin_freq = -1;`
	`166`	`+ unsigned long fin_freq;`
`167`	`167`
`168`	`168`	`duty = state->duty_cycle;`
`169`	`169`	`period = state->period;`