Skip to content

Commit 446cd6f

Browse files
Tian Taojarkkojs
authored andcommitted
char: tpm: move to use request_irq by IRQF_NO_AUTOEN flag
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting. Link: https://lore.kernel.org/patchwork/patch/1388765/ Signed-off-by: Tian Tao <[email protected]> Reviewed-by: Jarkko Sakkinen <[email protected]> Signed-off-by: Jarkko Sakkinen <[email protected]>
1 parent 114e433 commit 446cd6f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/char/tpm/tpm_tis_i2c_cr50.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,14 +706,14 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client,
706706

707707
if (client->irq > 0) {
708708
rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
709-
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
709+
IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
710+
IRQF_NO_AUTOEN,
710711
dev->driver->name, chip);
711712
if (rc < 0) {
712713
dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
713714
return rc;
714715
}
715716

716-
disable_irq(client->irq);
717717
priv->irq = client->irq;
718718
} else {
719719
dev_warn(dev, "No IRQ, will use %ums delay for TPM ready\n",

0 commit comments

Comments
 (0)