Skip to content

Commit 4472099

Browse files
committed
gcc-10: disable 'array-bounds' warning for now
This is another fine warning, related to the 'zero-length-bounds' one, but hitting the same historical code in the kernel. Because C didn't historically support flexible array members, we have code that instead uses a one-sized array, the same way we have cases of zero-sized arrays. The one-sized arrays come from either not wanting to use the gcc zero-sized array extension, or from a slight convenience-feature, where particularly for strings, the size of the structure now includes the allocation for the final NUL character. So with a "char name[1];" at the end of a structure, you can do things like v = my_malloc(sizeof(struct vendor) + strlen(name)); and avoid the "+1" for the terminator. Yes, the modern way to do that is with a flexible array, and using 'offsetof()' instead of 'sizeof()', and adding the "+1" by hand. That also technically gets the size "more correct" in that it avoids any alignment (and thus padding) issues, but this is another long-term cleanup thing that will not happen for 5.7. So disable the warning for now, even though it's potentially quite useful. Having a slew of warnings that then hide more urgent new issues is not an improvement. Signed-off-by: Linus Torvalds <[email protected]>
1 parent 5c45de2 commit 4472099

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -879,6 +879,7 @@ KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation)
879879

880880
# We'll want to enable this eventually, but it's not going away for 5.7 at least
881881
KBUILD_CFLAGS += $(call cc-disable-warning, zero-length-bounds)
882+
KBUILD_CFLAGS += $(call cc-disable-warning, array-bounds)
882883

883884
# Enabled with W=2, disabled by default as noisy
884885
KBUILD_CFLAGS += $(call cc-disable-warning, maybe-uninitialized)

0 commit comments

Comments
 (0)