Skip to content

Commit 44bd9a3

Browse files
Lee Jonesrafaeljw
authored andcommitted
cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues
Repair problems with formatting and missing attributes/parameters, and demote header comments which do not meet the required standards applicable to kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_lpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_gpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'policy' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:182: warning: Function parameter or member 'i' not described in 'idx_to_pstate' drivers/cpufreq/powernv-cpufreq.c:201: warning: Function parameter or member 'pstate' not described in 'pstate_to_idx' drivers/cpufreq/powernv-cpufreq.c:670: warning: Function parameter or member 't' not described in 'gpstate_timer_handler' drivers/cpufreq/powernv-cpufreq.c:670: warning: Excess function parameter 'data' description in 'gpstate_timer_handler' Signed-off-by: Lee Jones <[email protected]> Acked-by: Viresh Kumar <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 4a27aa9 commit 44bd9a3

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

drivers/cpufreq/powernv-cpufreq.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,14 @@
6464
* highest_lpstate_idx
6565
* @last_sampled_time: Time from boot in ms when global pstates were
6666
* last set
67-
* @last_lpstate_idx, Last set value of local pstate and global
68-
* last_gpstate_idx pstate in terms of cpufreq table index
67+
* @last_lpstate_idx: Last set value of local pstate and global
68+
* @last_gpstate_idx: pstate in terms of cpufreq table index
6969
* @timer: Is used for ramping down if cpu goes idle for
7070
* a long time with global pstate held high
7171
* @gpstate_lock: A spinlock to maintain synchronization between
7272
* routines called by the timer handler and
7373
* governer's target_index calls
74+
* @policy: Associated CPUFreq policy
7475
*/
7576
struct global_pstate_info {
7677
int highest_lpstate_idx;
@@ -170,7 +171,7 @@ static inline u8 extract_pstate(u64 pmsr_val, unsigned int shift)
170171

171172
/* Use following functions for conversions between pstate_id and index */
172173

173-
/**
174+
/*
174175
* idx_to_pstate : Returns the pstate id corresponding to the
175176
* frequency in the cpufreq frequency table
176177
* powernv_freqs indexed by @i.
@@ -188,7 +189,7 @@ static inline u8 idx_to_pstate(unsigned int i)
188189
return powernv_freqs[i].driver_data;
189190
}
190191

191-
/**
192+
/*
192193
* pstate_to_idx : Returns the index in the cpufreq frequencytable
193194
* powernv_freqs for the frequency whose corresponding
194195
* pstate id is @pstate.
@@ -660,7 +661,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates)
660661
/**
661662
* gpstate_timer_handler
662663
*
663-
* @data: pointer to cpufreq_policy on which timer was queued
664+
* @t: Timer context used to fetch global pstate info struct
664665
*
665666
* This handler brings down the global pstate closer to the local pstate
666667
* according quadratic equation. Queues a new timer if it is still not equal

0 commit comments

Comments
 (0)