Skip to content

Commit 455e135

Browse files
amoreton-xilinxkuba-moo
authored andcommitted
sfc: remove efx_writed_page_locked
From: Andy Moreton <[email protected]> efx_writed_page_locked is a workaround for Siena hardware that is not needed on later adapters, and has no callers. Remove it. Signed-off-by: Andy Moreton <[email protected]> Signed-off-by: Edward Cree <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5c98e89 commit 455e135

File tree

1 file changed

+0
-24
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+0
-24
lines changed

drivers/net/ethernet/sfc/io.h

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -217,28 +217,4 @@ _efx_writed_page(struct efx_nic *efx, const efx_dword_t *value,
217217
(reg) != 0xa1c), \
218218
page)
219219

220-
/* Write TIMER_COMMAND. This is a page-mapped 32-bit CSR, but a bug
221-
* in the BIU means that writes to TIMER_COMMAND[0] invalidate the
222-
* collector register.
223-
*/
224-
static inline void _efx_writed_page_locked(struct efx_nic *efx,
225-
const efx_dword_t *value,
226-
unsigned int reg,
227-
unsigned int page)
228-
{
229-
unsigned long flags __attribute__ ((unused));
230-
231-
if (page == 0) {
232-
spin_lock_irqsave(&efx->biu_lock, flags);
233-
efx_writed(efx, value, efx_paged_reg(efx, page, reg));
234-
spin_unlock_irqrestore(&efx->biu_lock, flags);
235-
} else {
236-
efx_writed(efx, value, efx_paged_reg(efx, page, reg));
237-
}
238-
}
239-
#define efx_writed_page_locked(efx, value, reg, page) \
240-
_efx_writed_page_locked(efx, value, \
241-
reg + BUILD_BUG_ON_ZERO((reg) != 0x420), \
242-
page)
243-
244220
#endif /* EFX_IO_H */

0 commit comments

Comments
 (0)