Skip to content

Commit 4563654

Browse files
Uwe Kleine-Königthierryreding
authored andcommitted
pwm: imx27: Don't disable clocks at device remove time
The .remove() callback is not supposed to modify hardware state. This is in the responsibility of the PWM consumer. After the PWM was disabled the clocks are off (apart from a bug that is fixed in the next patch), so unbinding the driver either stops the PWM (which it should not) or disables already disabled clocks yielding warnings from the clk core. So just drop the call to disable the clocks. (Which BTW was also in the wrong order because the call makes the PWM unfunctional and so should have come only after pwmchip_remove()). Fixes: 9f4c8f9 ("pwm: imx: Add ipg clock operation") Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
1 parent aad4e53 commit 4563654

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/pwm/pwm-imx27.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,6 @@ static int pwm_imx27_remove(struct platform_device *pdev)
358358

359359
imx = platform_get_drvdata(pdev);
360360

361-
pwm_imx27_clk_disable_unprepare(imx);
362-
363361
return pwmchip_remove(&imx->chip);
364362
}
365363

0 commit comments

Comments
 (0)