Skip to content

Commit 458bf63

Browse files
committed
Merge tag 'nf-25-02-13' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf
Pablo Neira Ayuso says: ==================== Netfilter fixes for net The following batch contains one revert for: 1) Revert flowtable entry teardown cycle when skbuff exceeds mtu to deal with DF flag unset scenarios. This is reverts a patch coming in the previous merge window (available in 6.14-rc releases). * tag 'nf-25-02-13' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf: Revert "netfilter: flowtable: teardown flow if cached mtu is stale" ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 0892b84 + cf56aa8 commit 458bf63

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

net/netfilter/nf_flow_table_ip.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,8 @@ static int nf_flow_offload_forward(struct nf_flowtable_ctx *ctx,
381381
flow = container_of(tuplehash, struct flow_offload, tuplehash[dir]);
382382

383383
mtu = flow->tuplehash[dir].tuple.mtu + ctx->offset;
384-
if (unlikely(nf_flow_exceeds_mtu(skb, mtu))) {
385-
flow_offload_teardown(flow);
384+
if (unlikely(nf_flow_exceeds_mtu(skb, mtu)))
386385
return 0;
387-
}
388386

389387
iph = (struct iphdr *)(skb_network_header(skb) + ctx->offset);
390388
thoff = (iph->ihl * 4) + ctx->offset;
@@ -662,10 +660,8 @@ static int nf_flow_offload_ipv6_forward(struct nf_flowtable_ctx *ctx,
662660
flow = container_of(tuplehash, struct flow_offload, tuplehash[dir]);
663661

664662
mtu = flow->tuplehash[dir].tuple.mtu + ctx->offset;
665-
if (unlikely(nf_flow_exceeds_mtu(skb, mtu))) {
666-
flow_offload_teardown(flow);
663+
if (unlikely(nf_flow_exceeds_mtu(skb, mtu)))
667664
return 0;
668-
}
669665

670666
ip6h = (struct ipv6hdr *)(skb_network_header(skb) + ctx->offset);
671667
thoff = sizeof(*ip6h) + ctx->offset;

0 commit comments

Comments
 (0)