Skip to content

Commit 45b7955

Browse files
Dan Carpenterdakr
authored andcommitted
nouveau/gsp/r535: remove a stray unlock in r535_gsp_rpc_send()
This unlock doesn't belong here and it leads to a double unlock in the caller, r535_gsp_rpc_push(). Fixes: 176fdcb ("drm/nouveau/gsp/r535: add support for booting GSP-RM") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Timur Tabi <[email protected]> Signed-off-by: Danilo Krummrich <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent e9ba37d commit 45b7955

File tree

1 file changed

+1
-3
lines changed
  • drivers/gpu/drm/nouveau/nvkm/subdev/gsp

1 file changed

+1
-3
lines changed

drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,10 +365,8 @@ r535_gsp_rpc_send(struct nvkm_gsp *gsp, void *argv, bool wait, u32 repc)
365365
}
366366

367367
ret = r535_gsp_cmdq_push(gsp, rpc);
368-
if (ret) {
369-
mutex_unlock(&gsp->cmdq.mutex);
368+
if (ret)
370369
return ERR_PTR(ret);
371-
}
372370

373371
if (wait) {
374372
msg = r535_gsp_msg_recv(gsp, fn, repc);

0 commit comments

Comments
 (0)