Skip to content

Commit 45d8b57

Browse files
Uwe Kleine-Königchanwoochoi
authored andcommitted
PM / devfreq: exynos-nocp: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent dd5a440 commit 45d8b57

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/devfreq/event/exynos-nocp.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,18 +275,16 @@ static int exynos_nocp_probe(struct platform_device *pdev)
275275
return 0;
276276
}
277277

278-
static int exynos_nocp_remove(struct platform_device *pdev)
278+
static void exynos_nocp_remove(struct platform_device *pdev)
279279
{
280280
struct exynos_nocp *nocp = platform_get_drvdata(pdev);
281281

282282
clk_disable_unprepare(nocp->clk);
283-
284-
return 0;
285283
}
286284

287285
static struct platform_driver exynos_nocp_driver = {
288286
.probe = exynos_nocp_probe,
289-
.remove = exynos_nocp_remove,
287+
.remove_new = exynos_nocp_remove,
290288
.driver = {
291289
.name = "exynos-nocp",
292290
.of_match_table = exynos_nocp_id_match,

0 commit comments

Comments
 (0)