Skip to content

Commit 4608908

Browse files
Max StaudtJiri Kosina
authored andcommitted
HID: playstation: DS4: Don't fail on FW/HW version request
Some third-party controllers can't report firmware/hardware version. Unlike for the DualSense, the driver does not use these values for anything in the DualShock 4 case, but merely exposes them via sysfs. They will simply be 0x0. Signed-off-by: Max Staudt <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 8f39af3 commit 4608908

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/hid/hid-playstation.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2558,8 +2558,8 @@ static struct ps_device *dualshock4_create(struct hid_device *hdev)
25582558

25592559
ret = dualshock4_get_firmware_info(ds4);
25602560
if (ret) {
2561-
hid_err(hdev, "Failed to get firmware info from DualShock4\n");
2562-
return ERR_PTR(ret);
2561+
hid_warn(hdev, "Failed to get firmware info from DualShock4\n");
2562+
hid_warn(hdev, "HW/FW version data in sysfs will be invalid.\n");
25632563
}
25642564

25652565
ret = ps_devices_list_add(ps_dev);

0 commit comments

Comments
 (0)