Skip to content

Commit 460b528

Browse files
ccpalexkuba-moo
authored andcommitted
net: ethernet: ti: cpsw: fix the comment regarding VLAN-aware ALE
In all 3 cases (cpsw, cpsw-new, am65-cpsw) ALE is being configured in VLAN-aware mode, while the comment states the opposite. Seems to be a typo copy-pasted from one driver to another. Fix the commend which has been puzzling some people (including me) for at least a decade. Link: https://lore.kernel.org/linux-arm-kernel/4699400.vD3TdgH1nR@localhost/ Link: https://lore.kernel.org/netdev/[email protected]/ Signed-off-by: Alexander Sverdlin <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 06cc878 commit 460b528

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

drivers/net/ethernet/ti/am65-cpsw-nuss.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
762762
ALE_DEFAULT_THREAD_ID, 0);
763763
cpsw_ale_control_set(common->ale, HOST_PORT_NUM,
764764
ALE_DEFAULT_THREAD_ENABLE, 1);
765-
/* switch to vlan unaware mode */
765+
/* switch to vlan aware mode */
766766
cpsw_ale_control_set(common->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, 1);
767767
cpsw_ale_control_set(common->ale, HOST_PORT_NUM,
768768
ALE_PORT_STATE, ALE_PORT_STATE_FORWARD);

drivers/net/ethernet/ti/cpsw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ static void cpsw_init_host_port(struct cpsw_priv *priv)
686686
soft_reset("cpsw", &cpsw->regs->soft_reset);
687687
cpsw_ale_start(cpsw->ale);
688688

689-
/* switch to vlan unaware mode */
689+
/* switch to vlan aware mode */
690690
cpsw_ale_control_set(cpsw->ale, HOST_PORT_NUM, ALE_VLAN_AWARE,
691691
CPSW_ALE_VLAN_AWARE);
692692
control_reg = readl(&cpsw->regs->control);

drivers/net/ethernet/ti/cpsw_new.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ static void cpsw_init_host_port(struct cpsw_priv *priv)
554554
soft_reset("cpsw", &cpsw->regs->soft_reset);
555555
cpsw_ale_start(cpsw->ale);
556556

557-
/* switch to vlan unaware mode */
557+
/* switch to vlan aware mode */
558558
cpsw_ale_control_set(cpsw->ale, HOST_PORT_NUM, ALE_VLAN_AWARE,
559559
CPSW_ALE_VLAN_AWARE);
560560
control_reg = readl(&cpsw->regs->control);

0 commit comments

Comments
 (0)