Skip to content

Commit 462fb75

Browse files
committed
Revert "parisc: Drop LDCW barrier in CAS code when running UP"
This reverts commit e6eb5fe. We need to optimize it differently. A follow up patch will correct it. Signed-off-by: Helge Deller <[email protected]> Cc: <[email protected]> # v5.2+
1 parent 3d05b8a commit 462fb75

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

arch/parisc/kernel/syscall.S

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -641,8 +641,7 @@ cas_action:
641641
2: stw %r24, 0(%r26)
642642
/* Free lock */
643643
#ifdef CONFIG_SMP
644-
98: LDCW 0(%sr2,%r20), %r1 /* Barrier */
645-
99: ALTERNATIVE(98b, 99b, ALT_COND_NO_SMP, INSN_NOP)
644+
LDCW 0(%sr2,%r20), %r1 /* Barrier */
646645
#endif
647646
stw %r20, 0(%sr2,%r20)
648647
#if ENABLE_LWS_DEBUG
@@ -659,8 +658,7 @@ cas_action:
659658
/* Error occurred on load or store */
660659
/* Free lock */
661660
#ifdef CONFIG_SMP
662-
98: LDCW 0(%sr2,%r20), %r1 /* Barrier */
663-
99: ALTERNATIVE(98b, 99b, ALT_COND_NO_SMP, INSN_NOP)
661+
LDCW 0(%sr2,%r20), %r1 /* Barrier */
664662
#endif
665663
stw %r20, 0(%sr2,%r20)
666664
#if ENABLE_LWS_DEBUG
@@ -864,8 +862,7 @@ cas2_action:
864862
cas2_end:
865863
/* Free lock */
866864
#ifdef CONFIG_SMP
867-
98: LDCW 0(%sr2,%r20), %r1 /* Barrier */
868-
99: ALTERNATIVE(98b, 99b, ALT_COND_NO_SMP, INSN_NOP)
865+
LDCW 0(%sr2,%r20), %r1 /* Barrier */
869866
#endif
870867
stw %r20, 0(%sr2,%r20)
871868
/* Enable interrupts */
@@ -878,8 +875,7 @@ cas2_end:
878875
/* Error occurred on load or store */
879876
/* Free lock */
880877
#ifdef CONFIG_SMP
881-
98: LDCW 0(%sr2,%r20), %r1 /* Barrier */
882-
99: ALTERNATIVE(98b, 99b, ALT_COND_NO_SMP, INSN_NOP)
878+
LDCW 0(%sr2,%r20), %r1 /* Barrier */
883879
#endif
884880
stw %r20, 0(%sr2,%r20)
885881
ssm PSW_SM_I, %r0

0 commit comments

Comments
 (0)