Skip to content

Commit 464b99e

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: lib: fix shellcheck errors
It looks like we missed these two errors recently: - SC2068: Double quote array expansions to avoid re-splitting elements. - SC2145: Argument mixes string and array. Use * or separate argument. Two simple fixes, it is not supposed to change the behaviour as the variable names should not have any spaces in their names. Still, better to fix them to easily spot new issues. Fixes: f265d31 ("selftests: mptcp: lib: use setup/cleanup_ns helpers") Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/20240712-upstream-net-next-20240712-selftests-mptcp-fix-shellcheck-v1-1-1cb7180db40a@kernel.org Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 22767ee commit 464b99e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/net/mptcp/mptcp_lib.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,8 @@ mptcp_lib_check_tools() {
428428
}
429429

430430
mptcp_lib_ns_init() {
431-
if ! setup_ns ${@}; then
432-
mptcp_lib_pr_fail "Failed to setup namespace ${@}"
431+
if ! setup_ns "${@}"; then
432+
mptcp_lib_pr_fail "Failed to setup namespaces ${*}"
433433
exit ${KSFT_FAIL}
434434
fi
435435

0 commit comments

Comments
 (0)