Skip to content

Commit 473baea

Browse files
Rafał Miłeckiffainelli
authored andcommitted
ARM: dts: BCM5301X: Explicitly disable unused switch CPU ports
When redescribing ports I assumed that missing "label" (like "cpu") means switch port isn't used. That was incorrect and I realized my change made Linux always use the first (5) CPU port (there are 3 of them). While above should technically be possible it often isn't correct: 1. Non-default switch ports are often connected to Ethernet interfaces not fully covered by vendor setup (they may miss MACs) 2. On some devices non-default ports require specifying fixed link This fixes network connectivity for some devices. It was reported & tested for Netgear R8000. It also affects Linksys EA9200 with its downstream DTS. Fixes: ba4aebc ("ARM: dts: BCM5301X: Describe switch ports in the main DTS") Signed-off-by: Rafał Miłecki <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Florian Fainelli <[email protected]>
1 parent b8d4f7c commit 473baea

20 files changed

+160
-0
lines changed

arch/arm/boot/dts/broadcom/bcm4708-buffalo-wzr-1166dhp-common.dtsi

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,5 +181,13 @@
181181
port@5 {
182182
label = "cpu";
183183
};
184+
185+
port@7 {
186+
status = "disabled";
187+
};
188+
189+
port@8 {
190+
status = "disabled";
191+
};
184192
};
185193
};

arch/arm/boot/dts/broadcom/bcm4708-luxul-xap-1510.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,13 @@
8585
port@5 {
8686
label = "cpu";
8787
};
88+
89+
port@7 {
90+
status = "disabled";
91+
};
92+
93+
port@8 {
94+
status = "disabled";
95+
};
8896
};
8997
};

arch/arm/boot/dts/broadcom/bcm4708-luxul-xwc-1000.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,13 @@
8888
port@5 {
8989
label = "cpu";
9090
};
91+
92+
port@7 {
93+
status = "disabled";
94+
};
95+
96+
port@8 {
97+
status = "disabled";
98+
};
9199
};
92100
};

arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,5 +122,13 @@
122122
port@5 {
123123
label = "cpu";
124124
};
125+
126+
port@7 {
127+
status = "disabled";
128+
};
129+
130+
port@8 {
131+
status = "disabled";
132+
};
125133
};
126134
};

arch/arm/boot/dts/broadcom/bcm4708-smartrg-sr400ac.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,14 @@
145145
port@5 {
146146
label = "cpu";
147147
};
148+
149+
port@7 {
150+
status = "disabled";
151+
};
152+
153+
port@8 {
154+
status = "disabled";
155+
};
148156
};
149157
};
150158

arch/arm/boot/dts/broadcom/bcm47081-buffalo-wzr-600dhp2.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,5 +145,13 @@
145145
port@5 {
146146
label = "cpu";
147147
};
148+
149+
port@7 {
150+
status = "disabled";
151+
};
152+
153+
port@8 {
154+
status = "disabled";
155+
};
148156
};
149157
};

arch/arm/boot/dts/broadcom/bcm47081-luxul-xap-1410.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,13 @@
8181
port@5 {
8282
label = "cpu";
8383
};
84+
85+
port@7 {
86+
status = "disabled";
87+
};
88+
89+
port@8 {
90+
status = "disabled";
91+
};
8492
};
8593
};

arch/arm/boot/dts/broadcom/bcm47081-luxul-xwr-1200.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,5 +148,13 @@
148148
port@5 {
149149
label = "cpu";
150150
};
151+
152+
port@7 {
153+
status = "disabled";
154+
};
155+
156+
port@8 {
157+
status = "disabled";
158+
};
151159
};
152160
};

arch/arm/boot/dts/broadcom/bcm4709-netgear-r8000.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,14 @@
227227
label = "wan";
228228
};
229229

230+
port@5 {
231+
status = "disabled";
232+
};
233+
234+
port@7 {
235+
status = "disabled";
236+
};
237+
230238
port@8 {
231239
label = "cpu";
232240
};

arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,14 @@
160160
nvmem-cell-names = "mac-address";
161161
};
162162

163+
port@5 {
164+
status = "disabled";
165+
};
166+
167+
port@7 {
168+
status = "disabled";
169+
};
170+
163171
port@8 {
164172
label = "cpu";
165173
};

0 commit comments

Comments
 (0)