Skip to content

Commit 475feec

Browse files
committed
ALSA: hda - Downgrade error message for single-cmd fallback
We made the error message for the CORB/RIRB communication clearer by upgrading to dev_WARN() so that user can notice better. But this struck us like a boomerang: now it caught syzbot and reported back as a fatal issue although it's not really any too serious bug that worth for stopping the whole system. OK, OK, let's be softy, downgrade it to the standard dev_err() again. Fixes: dd65f7e ("ALSA: hda - Show the fatal CORB/RIRB error more clearly") Reported-by: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 6fd739c commit 475feec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/pci/hda/hda_controller.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr,
883883
return -EAGAIN; /* give a chance to retry */
884884
}
885885

886-
dev_WARN(chip->card->dev,
886+
dev_err(chip->card->dev,
887887
"azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",
888888
bus->last_cmd[addr]);
889889
chip->single_cmd = 1;

0 commit comments

Comments
 (0)