scsi: ufs: ufshcd: Delete unnecessary NULL check

Dan Carpenter · martinkpetersen · commit 476e45923b5d · 2022-05-23T23:24:10.000-04:00
The 'info' pointer points to somewhere in the middle of the 'hba' struct. It can't possibly be NULL. Delete the NULL check. Link: https://lore.kernel.org/r/YotFotj43TkB8Rid@kili Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
@@ -8445,10 +8445,7 @@ static int ufshcd_init_hba_vreg(struct ufs_hba *hba)
 {
 	struct ufs_vreg_info *info = &hba->vreg_info;
 
-	if (info)
-		return ufshcd_get_vreg(hba->dev, info->vdd_hba);
-
-	return 0;
+	return ufshcd_get_vreg(hba->dev, info->vdd_hba);
 }
 
 static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on)

Original file line number	Diff line number	Diff line change
`@@ -8445,10 +8445,7 @@ static int ufshcd_init_hba_vreg(struct ufs_hba *hba)`
`8445`	`8445`	`{`
`8446`	`8446`	`struct ufs_vreg_info *info = &hba->vreg_info;`
`8447`	`8447`
`8448`		`- if (info)`
`8449`		`- return ufshcd_get_vreg(hba->dev, info->vdd_hba);`
`8450`		`-`
`8451`		`- return 0;`
	`8448`	`+ return ufshcd_get_vreg(hba->dev, info->vdd_hba);`
`8452`	`8449`	`}`
`8453`	`8450`
`8454`	`8451`	`static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on)`