Skip to content

Commit 478c60c

Browse files
Wolfram Sangstorulf
authored andcommitted
Revert "mmc: tmio: remove workaround for NON_REMOVABLE"
This reverts commit 7a7dab2. We found out that there is still a race with RuntimePM. This can lead to a hang when accessing the eMMC in some situations. Revert this change until the RPM issue is fixed. Reported-by: Geert Uytterhoeven <[email protected]> Tested-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Wolfram Sang <[email protected]> Signed-off-by: Ulf Hansson <[email protected]>
1 parent 1696d96 commit 478c60c

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/mmc/host/tmio_mmc_core.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,6 +1208,15 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host)
12081208
if (!_host->reset)
12091209
_host->reset = tmio_mmc_reset;
12101210

1211+
/*
1212+
* On Gen2+, eMMC with NONREMOVABLE currently fails because native
1213+
* hotplug gets disabled. It seems RuntimePM related yet we need further
1214+
* research. Since we are planning a PM overhaul anyway, let's enforce
1215+
* for now the device being active by enabling native hotplug always.
1216+
*/
1217+
if (pdata->flags & TMIO_MMC_MIN_RCAR2)
1218+
_host->native_hotplug = true;
1219+
12111220
/*
12121221
* While using internal tmio hardware logic for card detection, we need
12131222
* to ensure it stays powered for it to work.

0 commit comments

Comments
 (0)