NFS: Don't trace an uninitialised value

Trond Myklebust · Trond Myklebust · commit 4798f8058d6b · 2021-11-05T12:58:41.000-04:00
If fhandle is NULL or fattr is NULL, then 'error' is uninitialised.

Reported-by: Nathan Chancellor &lt;nathan@kernel.org&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
Reviewed-by: Nathan Chancellor &lt;nathan@kernel.org&gt;
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
@@ -1814,7 +1814,7 @@ struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, unsigned in
 	}
 	nfs_set_verifier(dentry, dir_verifier);
 out_label:
-	trace_nfs_lookup_exit(dir, dentry, flags, error);
+	trace_nfs_lookup_exit(dir, dentry, flags, PTR_ERR_OR_ZERO(res));
 	nfs4_label_free(label);
 out:
 	nfs_free_fattr(fattr);

Original file line number	Diff line number	Diff line change
`@@ -1814,7 +1814,7 @@ struct dentry nfs_lookup(struct inode dir, struct dentry * dentry, unsigned in`
`1814`	`1814`	`}`
`1815`	`1815`	`nfs_set_verifier(dentry, dir_verifier);`
`1816`	`1816`	`out_label:`
`1817`		`- trace_nfs_lookup_exit(dir, dentry, flags, error);`
	`1817`	`+ trace_nfs_lookup_exit(dir, dentry, flags, PTR_ERR_OR_ZERO(res));`
`1818`	`1818`	`nfs4_label_free(label);`
`1819`	`1819`	`out:`
`1820`	`1820`	`nfs_free_fattr(fattr);`