Skip to content

Commit 47b3e2f

Browse files
juhosgvinodkoul
authored andcommitted
phy: qcom: m31: match requested regulator name with dt schema
According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V supply regulator must be defined via the 'vdd-supply' property. The driver however requests for the 'vdda-phy' regulator which results in the following message when the driver is probed on a IPQ5018 based board with a device tree matching to the schema: qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator qcom-m31usb-phy 5b000.phy: Registered M31 USB phy This means that the regulator specified in the device tree never gets enabled. Change the driver to use the 'vdd' name for the regulator as per defined in the schema in order to ensure that the corresponding regulator gets enabled. Fixes: 08e49af ("phy: qcom: Introduce M31 USB PHY driver") Reviewed-by: Varadarajan Narayanan <[email protected]> Signed-off-by: Gabor Juhos <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent ee13e1f commit 47b3e2f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/phy/qualcomm/phy-qcom-m31.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
297297
return dev_err_probe(dev, PTR_ERR(qphy->phy),
298298
"failed to create phy\n");
299299

300-
qphy->vreg = devm_regulator_get(dev, "vdda-phy");
300+
qphy->vreg = devm_regulator_get(dev, "vdd");
301301
if (IS_ERR(qphy->vreg))
302302
return dev_err_probe(dev, PTR_ERR(qphy->vreg),
303303
"failed to get vreg\n");

0 commit comments

Comments
 (0)