Skip to content

Commit 47cc0ed

Browse files
borkmannAlexei Starovoitov
authored andcommitted
bpf: Add bpf_probe_read_{user, kernel}_str() to do_refine_retval_range
Given bpf_probe_read{,str}() BPF helpers are now only available under CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE, we need to add the drop-in replacements of bpf_probe_read_{kernel,user}_str() to do_refine_retval_range() as well to avoid hitting the same issue as in 849fa50 ("bpf/verifier: refine retval R0 state for bpf_get_stack helper"). Signed-off-by: Daniel Borkmann <[email protected]> Signed-off-by: Alexei Starovoitov <[email protected]> Acked-by: John Fastabend <[email protected]> Acked-by: Yonghong Song <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
1 parent 0ebeea8 commit 47cc0ed

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

kernel/bpf/verifier.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4340,7 +4340,9 @@ static void do_refine_retval_range(struct bpf_reg_state *regs, int ret_type,
43404340

43414341
if (ret_type != RET_INTEGER ||
43424342
(func_id != BPF_FUNC_get_stack &&
4343-
func_id != BPF_FUNC_probe_read_str))
4343+
func_id != BPF_FUNC_probe_read_str &&
4344+
func_id != BPF_FUNC_probe_read_kernel_str &&
4345+
func_id != BPF_FUNC_probe_read_user_str))
43444346
return;
43454347

43464348
ret_reg->smax_value = meta->msize_max_value;

0 commit comments

Comments
 (0)