Skip to content

Commit 47d0d7d

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: remove unneeded return value of __insert_discard_tree()
We never use return value of __insert_discard_tree(), so remove it. Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 84597b1 commit 47d0d7d

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

fs/f2fs/segment.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1221,7 +1221,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
12211221
return err;
12221222
}
12231223

1224-
static struct discard_cmd *__insert_discard_tree(struct f2fs_sb_info *sbi,
1224+
static void __insert_discard_tree(struct f2fs_sb_info *sbi,
12251225
struct block_device *bdev, block_t lstart,
12261226
block_t start, block_t len,
12271227
struct rb_node **insert_p,
@@ -1230,7 +1230,6 @@ static struct discard_cmd *__insert_discard_tree(struct f2fs_sb_info *sbi,
12301230
struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
12311231
struct rb_node **p;
12321232
struct rb_node *parent = NULL;
1233-
struct discard_cmd *dc = NULL;
12341233
bool leftmost = true;
12351234

12361235
if (insert_p && insert_parent) {
@@ -1242,12 +1241,8 @@ static struct discard_cmd *__insert_discard_tree(struct f2fs_sb_info *sbi,
12421241
p = f2fs_lookup_rb_tree_for_insert(sbi, &dcc->root, &parent,
12431242
lstart, &leftmost);
12441243
do_insert:
1245-
dc = __attach_discard_cmd(sbi, bdev, lstart, start, len, parent,
1244+
__attach_discard_cmd(sbi, bdev, lstart, start, len, parent,
12461245
p, leftmost);
1247-
if (!dc)
1248-
return NULL;
1249-
1250-
return dc;
12511246
}
12521247

12531248
static void __relocate_discard_cmd(struct discard_cmd_control *dcc,

0 commit comments

Comments
 (0)