Skip to content

Commit 47d4bb6

Browse files
AngeloGioacchino Del RegnoChun-Kuang Hu
authored andcommitted
drm/mediatek: mtk_dpi: Simplify with devm_drm_bridge_add()
Change drm_bridge_add() to its devm variant to slightly simplify the probe function. Signed-off-by: AngeloGioacchino Del Regno <[email protected]> Reviewed-by: Fei Shao <[email protected]> Reviewed-by: CK Hu <[email protected]> Link: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/ Signed-off-by: Chun-Kuang Hu <[email protected]>
1 parent 63ee943 commit 47d4bb6

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/gpu/drm/mediatek/mtk_dpi.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct platform_device *pdev)
10901090
dpi->bridge.of_node = dev->of_node;
10911091
dpi->bridge.type = DRM_MODE_CONNECTOR_DPI;
10921092

1093-
drm_bridge_add(&dpi->bridge);
1093+
ret = devm_drm_bridge_add(dev, &dpi->bridge);
1094+
if (ret)
1095+
return ret;
10941096

10951097
ret = component_add(dev, &mtk_dpi_component_ops);
10961098
if (ret) {
1097-
drm_bridge_remove(&dpi->bridge);
10981099
dev_err(dev, "Failed to add component: %d\n", ret);
10991100
return ret;
11001101
}
@@ -1104,10 +1105,7 @@ static int mtk_dpi_probe(struct platform_device *pdev)
11041105

11051106
static int mtk_dpi_remove(struct platform_device *pdev)
11061107
{
1107-
struct mtk_dpi *dpi = platform_get_drvdata(pdev);
1108-
11091108
component_del(&pdev->dev, &mtk_dpi_component_ops);
1110-
drm_bridge_remove(&dpi->bridge);
11111109

11121110
return 0;
11131111
}

0 commit comments

Comments
 (0)