Skip to content

Commit 486fd58

Browse files
AndreySVakpm00
authored andcommitted
zram: don't free statically defined names
When CONFIG_ZRAM_MULTI_COMP isn't set ZRAM_SECONDARY_COMP can hold default_compressor, because it's the same offset as ZRAM_PRIMARY_COMP, so we need to make sure that we don't attempt to kfree() the statically defined compressor name. This is detected by KASAN. ================================================================== Call trace: kfree+0x60/0x3a0 zram_destroy_comps+0x98/0x198 [zram] zram_reset_device+0x22c/0x4a8 [zram] reset_store+0x1bc/0x2d8 [zram] dev_attr_store+0x44/0x80 sysfs_kf_write+0xfc/0x188 kernfs_fop_write_iter+0x28c/0x428 vfs_write+0x4dc/0x9b8 ksys_write+0x100/0x1f8 __arm64_sys_write+0x74/0xb8 invoke_syscall+0xd8/0x260 el0_svc_common.constprop.0+0xb4/0x240 do_el0_svc+0x48/0x68 el0_svc+0x40/0xc8 el0t_64_sync_handler+0x120/0x130 el0t_64_sync+0x190/0x198 ================================================================== Link: https://lkml.kernel.org/r/[email protected] Fixes: 684826f ("zram: free secondary algorithms names") Signed-off-by: Andrey Skvortsov <[email protected]> Reviewed-by: Sergey Senozhatsky <[email protected]> Reported-by: Venkat Rao Bagalkote <[email protected]> Closes: https://lore.kernel.org/lkml/[email protected]/ Tested-by: Venkat Rao Bagalkote <[email protected]> Cc: Christophe JAILLET <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Minchan Kim <[email protected]> Cc: Sergey Senozhatsky <[email protected]> Cc: Venkat Rao Bagalkote <[email protected]> Cc: Chris Li <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent a530bbc commit 486fd58

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/block/zram/zram_drv.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2115,8 +2115,10 @@ static void zram_destroy_comps(struct zram *zram)
21152115
zram->num_active_comps--;
21162116
}
21172117

2118-
for (prio = ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio++) {
2119-
kfree(zram->comp_algs[prio]);
2118+
for (prio = ZRAM_PRIMARY_COMP; prio < ZRAM_MAX_COMPS; prio++) {
2119+
/* Do not free statically defined compression algorithms */
2120+
if (zram->comp_algs[prio] != default_compressor)
2121+
kfree(zram->comp_algs[prio]);
21202122
zram->comp_algs[prio] = NULL;
21212123
}
21222124

0 commit comments

Comments
 (0)