Skip to content

Commit 4878f9f

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: join: validate fullmesh endp on 1st sf
This case was not covered, and the wrong ID was set before the previous commit. The rest is not modified, it is just that it will increase the code coverage. The right address ID can be verified by looking at the packet traces. We could automate that using Netfilter with some cBPF code for example, but that's always a bit cryptic. Packetdrill seems better fitted for that. Fixes: 4f49d63 ("selftests: mptcp: add fullmesh testcases") Cc: [email protected] Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 09355f7 commit 4878f9f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3059,6 +3059,7 @@ fullmesh_tests()
30593059
pm_nl_set_limits $ns1 1 3
30603060
pm_nl_set_limits $ns2 1 3
30613061
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal
3062+
pm_nl_add_endpoint $ns2 10.0.1.2 flags subflow,fullmesh
30623063
fullmesh=1 speed=slow \
30633064
run_tests $ns1 $ns2 10.0.1.1
30643065
chk_join_nr 3 3 3

0 commit comments

Comments
 (0)