Skip to content

Commit 48b47f0

Browse files
namjaejeonsmfrench
authored andcommitted
ksmbd: fix uninitialized pointer read in ksmbd_vfs_rename()
Uninitialized rd.delegated_inode can be used in vfs_rename(). Fix this by setting rd.delegated_inode to NULL to avoid the uninitialized read. Fixes: 74d7970 ("ksmbd: fix racy issue from using ->d_parent and ->d_name") Reported-by: Coverity Scan <[email protected]> Signed-off-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 0d85b27 commit 48b47f0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/smb/server/vfs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,7 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path,
743743
rd.new_dir = new_path.dentry->d_inode,
744744
rd.new_dentry = new_dentry,
745745
rd.flags = flags,
746+
rd.delegated_inode = NULL,
746747
err = vfs_rename(&rd);
747748
if (err)
748749
ksmbd_debug(VFS, "vfs_rename failed err %d\n", err);

0 commit comments

Comments
 (0)