Skip to content

Commit 48e0150

Browse files
Chris Chiutiwai
authored andcommitted
ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC
ASUS reported that there's an bass speaker in addition to internal speaker and it uses DAC 0x02. It was not enabled in the commit 436e255 ("ALSA: hda/realtek - Enable internal speaker of ASUS UX431FLC") which only enables the amplifier and the front speaker. This commit enables the bass speaker on top of the aforementioned work to improve the acoustic experience. Fixes: 436e255 ("ALSA: hda/realtek - Enable internal speaker of ASUS UX431FLC") Signed-off-by: Chris Chiu <[email protected]> Signed-off-by: Jian-Hong Pan <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 0aec96f commit 48e0150

File tree

1 file changed

+18
-20
lines changed

1 file changed

+18
-20
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5905,11 +5905,12 @@ enum {
59055905
ALC256_FIXUP_ASUS_HEADSET_MIC,
59065906
ALC256_FIXUP_ASUS_MIC_NO_PRESENCE,
59075907
ALC299_FIXUP_PREDATOR_SPK,
5908-
ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC,
59095908
ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE,
5910-
ALC294_FIXUP_ASUS_INTSPK_GPIO,
59115909
ALC289_FIXUP_DELL_SPK2,
59125910
ALC289_FIXUP_DUAL_SPK,
5911+
ALC294_FIXUP_SPK2_TO_DAC1,
5912+
ALC294_FIXUP_ASUS_DUAL_SPK,
5913+
59135914
};
59145915

59155916
static const struct hda_fixup alc269_fixups[] = {
@@ -6984,16 +6985,6 @@ static const struct hda_fixup alc269_fixups[] = {
69846985
{ }
69856986
}
69866987
},
6987-
[ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC] = {
6988-
.type = HDA_FIXUP_PINS,
6989-
.v.pins = (const struct hda_pintbl[]) {
6990-
{ 0x14, 0x411111f0 }, /* disable confusing internal speaker */
6991-
{ 0x19, 0x04a11150 }, /* use as headset mic, without its own jack detect */
6992-
{ }
6993-
},
6994-
.chained = true,
6995-
.chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
6996-
},
69976988
[ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE] = {
69986989
.type = HDA_FIXUP_PINS,
69996990
.v.pins = (const struct hda_pintbl[]) {
@@ -7004,13 +6995,6 @@ static const struct hda_fixup alc269_fixups[] = {
70046995
.chained = true,
70056996
.chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE
70066997
},
7007-
[ALC294_FIXUP_ASUS_INTSPK_GPIO] = {
7008-
.type = HDA_FIXUP_FUNC,
7009-
/* The GPIO must be pulled to initialize the AMP */
7010-
.v.func = alc_fixup_gpio4,
7011-
.chained = true,
7012-
.chain_id = ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC
7013-
},
70146998
[ALC289_FIXUP_DELL_SPK2] = {
70156999
.type = HDA_FIXUP_PINS,
70167000
.v.pins = (const struct hda_pintbl[]) {
@@ -7026,6 +7010,20 @@ static const struct hda_fixup alc269_fixups[] = {
70267010
.chained = true,
70277011
.chain_id = ALC289_FIXUP_DELL_SPK2
70287012
},
7013+
[ALC294_FIXUP_SPK2_TO_DAC1] = {
7014+
.type = HDA_FIXUP_FUNC,
7015+
.v.func = alc285_fixup_speaker2_to_dac1,
7016+
.chained = true,
7017+
.chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC
7018+
},
7019+
[ALC294_FIXUP_ASUS_DUAL_SPK] = {
7020+
.type = HDA_FIXUP_FUNC,
7021+
/* The GPIO must be pulled to initialize the AMP */
7022+
.v.func = alc_fixup_gpio4,
7023+
.chained = true,
7024+
.chain_id = ALC294_FIXUP_SPK2_TO_DAC1
7025+
},
7026+
70297027
};
70307028

70317029
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7187,7 +7185,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
71877185
SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK),
71887186
SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
71897187
SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
7190-
SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_INTSPK_GPIO),
7188+
SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
71917189
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
71927190
SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
71937191
SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC),

0 commit comments

Comments
 (0)