Skip to content

Commit 490e6c9

Browse files
yongzhi1broonie
authored andcommitted
ASoC: SOF: topology: remove incorrect widget id in error message
In sof_widget_ready() function, the shift field of struct snd_soc_tplg_dapm_widget is incorrectly used to print widget id in dev_err(scomp->dev, "error: failed to add widget id %d ..", this patch removes the useless tw->shift from the error output. Reviewed-by: Ranjani Sridharan <[email protected]> Signed-off-by: Yong Zhi <[email protected]> Signed-off-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent b32487c commit 490e6c9

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

sound/soc/sof/topology.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1531,10 +1531,9 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
15311531
/* check token parsing reply */
15321532
if (ret < 0) {
15331533
dev_err(scomp->dev,
1534-
"error: failed to add widget id %d type %d name : %s stream %s\n",
1535-
tw->shift, swidget->id, tw->name,
1536-
strnlen(tw->sname, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) > 0
1537-
? tw->sname : "none");
1534+
"failed to add widget type %d name : %s stream %s\n",
1535+
swidget->id, tw->name, strnlen(tw->sname, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) > 0
1536+
? tw->sname : "none");
15381537
goto widget_free;
15391538
}
15401539

0 commit comments

Comments
 (0)