cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

dhananjay-AMD · vireshk · commit 49243adc715e · 2024-09-04T20:43:58.000+05:30
Fix the reference counting of cpufreq_policy object in amd_pstate_update() function by adding the missing cpufreq_cpu_put(). Fixes: e8f555d ("cpufreq/amd-pstate: fix setting policy current frequency value") Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com> Reviewed-by: Perry Yuan <perry.yuan@amd.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
@@ -554,12 +554,15 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
 	}
 
 	if (value == prev)
-		return;
+		goto cpufreq_policy_put;
 
 	WRITE_ONCE(cpudata->cppc_req_cached, value);
 
 	amd_pstate_update_perf(cpudata, min_perf, des_perf,
 			       max_perf, fast_switch);
+
+cpufreq_policy_put:
+	cpufreq_cpu_put(policy);
 }
 
 static int amd_pstate_verify(struct cpufreq_policy_data *policy)

Original file line number	Diff line number	Diff line change
`@@ -554,12 +554,15 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,`
`554`	`554`	`}`
`555`	`555`
`556`	`556`	`if (value == prev)`
`557`		`- return;`
	`557`	`+ goto cpufreq_policy_put;`
`558`	`558`
`559`	`559`	`WRITE_ONCE(cpudata->cppc_req_cached, value);`
`560`	`560`
`561`	`561`	`amd_pstate_update_perf(cpudata, min_perf, des_perf,`
`562`	`562`	`max_perf, fast_switch);`
	`563`	`+`
	`564`	`+cpufreq_policy_put:`
	`565`	`+ cpufreq_cpu_put(policy);`
`563`	`566`	`}`
`564`	`567`
`565`	`568`	`static int amd_pstate_verify(struct cpufreq_policy_data *policy)`