Skip to content

Commit 492b119

Browse files
committed
platform/x86: x86-android-tablets: Pass struct device to init()
Pass a struct device pointer for x86_android_tablet_device to the board specific init() functions, so that these functions can use this for e.g. devm_*() functions. Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent ac0729c commit 492b119

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

drivers/platform/x86/x86-android-tablets/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ static __init int x86_android_tablet_probe(struct platform_device *pdev)
341341
gpiod_add_lookup_table(gpiod_lookup_tables[i]);
342342

343343
if (dev_info->init) {
344-
ret = dev_info->init();
344+
ret = dev_info->init(&pdev->dev);
345345
if (ret < 0) {
346346
x86_android_tablet_remove(pdev);
347347
return ret;

drivers/platform/x86/x86-android-tablets/lenovo.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ static struct gpiod_lookup_table * const lenovo_yb1_x90_gpios[] = {
230230
NULL
231231
};
232232

233-
static int __init lenovo_yb1_x90_init(void)
233+
static int __init lenovo_yb1_x90_init(struct device *dev)
234234
{
235235
/* Enable the regulators used by the touchscreens */
236236

@@ -412,7 +412,7 @@ static struct gpiod_lookup_table * const lenovo_yoga_tab2_830_1050_gpios[] = {
412412
NULL
413413
};
414414

415-
static int __init lenovo_yoga_tab2_830_1050_init(void);
415+
static int __init lenovo_yoga_tab2_830_1050_init(struct device *dev);
416416
static void lenovo_yoga_tab2_830_1050_exit(void);
417417

418418
const struct x86_dev_info lenovo_yoga_tab2_830_1050_info __initconst = {
@@ -534,7 +534,7 @@ static int lenovo_yoga_tab2_830_1050_power_off(struct sys_off_data *data)
534534
return NOTIFY_DONE;
535535
}
536536

537-
static int __init lenovo_yoga_tab2_830_1050_init(void)
537+
static int __init lenovo_yoga_tab2_830_1050_init(struct device *dev)
538538
{
539539
int ret;
540540

@@ -731,7 +731,7 @@ const char * const lenovo_yoga_tab2_1380_modules[] __initconst = {
731731
NULL
732732
};
733733

734-
static int __init lenovo_yoga_tab2_1380_init(void)
734+
static int __init lenovo_yoga_tab2_1380_init(struct device *dev)
735735
{
736736
int ret;
737737

@@ -978,7 +978,7 @@ static const struct x86_spi_dev_info lenovo_yt3_spi_devs[] __initconst = {
978978
}
979979
};
980980

981-
static int __init lenovo_yt3_init(void)
981+
static int __init lenovo_yt3_init(struct device *dev)
982982
{
983983
int ret;
984984

drivers/platform/x86/x86-android-tablets/other.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ static const struct x86_i2c_client_info chuwi_hi8_i2c_clients[] __initconst = {
183183
},
184184
};
185185

186-
static int __init chuwi_hi8_init(void)
186+
static int __init chuwi_hi8_init(struct device *dev)
187187
{
188188
/*
189189
* Avoid the acpi_unregister_gsi() call in x86_acpi_irq_helper_get()
@@ -244,7 +244,7 @@ const struct x86_dev_info cyberbook_t116_info __initconst = {
244244
#define CZC_EC_EXTRA_PORT 0x68
245245
#define CZC_EC_ANDROID_KEYS 0x63
246246

247-
static int __init czc_p10t_init(void)
247+
static int __init czc_p10t_init(struct device *dev)
248248
{
249249
/*
250250
* The device boots up in "Windows 7" mode, when the home button sends a
@@ -662,7 +662,7 @@ static const struct software_node *ktd2026_node_group[] = {
662662
NULL
663663
};
664664

665-
static int __init xiaomi_mipad2_init(void)
665+
static int __init xiaomi_mipad2_init(struct device *dev)
666666
{
667667
return software_node_register_node_group(ktd2026_node_group);
668668
}

drivers/platform/x86/x86-android-tablets/x86-android-tablets.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ struct x86_dev_info {
8989
int pdev_count;
9090
int serdev_count;
9191
int gpio_button_count;
92-
int (*init)(void);
92+
int (*init)(struct device *dev);
9393
void (*exit)(void);
9494
};
9595

0 commit comments

Comments
 (0)