Skip to content

Commit 497f68c

Browse files
committed
PCI/MSI: Use guard(msi_desc_lock) where applicable
Convert the trivial cases of msi_desc_lock/unlock() pairs. No functional change. Signed-off-by: Thomas Gleixner <[email protected]> Acked-by: Bjorn Helgaas <[email protected]> Link: https://lore.kernel.org/all/[email protected]
1 parent 8f3315c commit 497f68c

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

drivers/pci/msi/api.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,9 @@ void pci_disable_msi(struct pci_dev *dev)
5353
if (!pci_msi_enabled() || !dev || !dev->msi_enabled)
5454
return;
5555

56-
msi_lock_descs(&dev->dev);
56+
guard(msi_descs_lock)(&dev->dev);
5757
pci_msi_shutdown(dev);
5858
pci_free_msi_irqs(dev);
59-
msi_unlock_descs(&dev->dev);
6059
}
6160
EXPORT_SYMBOL(pci_disable_msi);
6261

@@ -196,10 +195,9 @@ void pci_disable_msix(struct pci_dev *dev)
196195
if (!pci_msi_enabled() || !dev || !dev->msix_enabled)
197196
return;
198197

199-
msi_lock_descs(&dev->dev);
198+
guard(msi_descs_lock)(&dev->dev);
200199
pci_msix_shutdown(dev);
201200
pci_free_msi_irqs(dev);
202-
msi_unlock_descs(&dev->dev);
203201
}
204202
EXPORT_SYMBOL(pci_disable_msix);
205203

drivers/pci/msi/msi.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -870,13 +870,13 @@ void __pci_restore_msix_state(struct pci_dev *dev)
870870

871871
write_msg = arch_restore_msi_irqs(dev);
872872

873-
msi_lock_descs(&dev->dev);
874-
msi_for_each_desc(entry, &dev->dev, MSI_DESC_ALL) {
875-
if (write_msg)
876-
__pci_write_msi_msg(entry, &entry->msg);
877-
pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
873+
scoped_guard (msi_descs_lock, &dev->dev) {
874+
msi_for_each_desc(entry, &dev->dev, MSI_DESC_ALL) {
875+
if (write_msg)
876+
__pci_write_msi_msg(entry, &entry->msg);
877+
pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
878+
}
878879
}
879-
msi_unlock_descs(&dev->dev);
880880

881881
pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
882882
}

0 commit comments

Comments
 (0)