Skip to content

Commit 49d2a1e

Browse files
lategoodbyestorulf
authored andcommitted
pmdomain: raspberrypi-power: Adjust packet definition
According to the official Mailbox property interface the second part of RPI_FIRMWARE_SET_POWER_STATE ( and so on ...) is named state because it represent u32 flags and just the lowest bit is for on/off. So rename it to align with documentation and prepare the driver for further changes. Link: https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface Signed-off-by: Stefan Wahren <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent 8287e9e commit 49d2a1e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/pmdomain/bcm/raspberrypi-power.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ struct rpi_power_domains {
4141
*/
4242
struct rpi_power_domain_packet {
4343
u32 domain;
44-
u32 on;
44+
u32 state;
4545
};
4646

4747
/*
@@ -53,7 +53,7 @@ static int rpi_firmware_set_power(struct rpi_power_domain *rpi_domain, bool on)
5353
struct rpi_power_domain_packet packet;
5454

5555
packet.domain = rpi_domain->domain;
56-
packet.on = on;
56+
packet.state = on;
5757
return rpi_firmware_property(rpi_domain->fw,
5858
rpi_domain->old_interface ?
5959
RPI_FIRMWARE_SET_POWER_STATE :
@@ -142,13 +142,13 @@ rpi_has_new_domain_support(struct rpi_power_domains *rpi_domains)
142142
int ret;
143143

144144
packet.domain = RPI_POWER_DOMAIN_ARM;
145-
packet.on = ~0;
145+
packet.state = ~0;
146146

147147
ret = rpi_firmware_property(rpi_domains->fw,
148148
RPI_FIRMWARE_GET_DOMAIN_STATE,
149149
&packet, sizeof(packet));
150150

151-
return ret == 0 && packet.on != ~0;
151+
return ret == 0 && packet.state != ~0;
152152
}
153153

154154
static int rpi_power_probe(struct platform_device *pdev)

0 commit comments

Comments
 (0)