Skip to content

Commit 49d8c5f

Browse files
stefano-garzarellamstsirkin
authored andcommitted
vhost/vsock: fix incorrect used length reported to the guest
The "used length" reported by calling vhost_add_used() must be the number of bytes written by the device (using "in" buffers). In vhost_vsock_handle_tx_kick() the device only reads the guest buffers (they are all "out" buffers), without writing anything, so we must pass 0 as "used length" to comply virtio spec. Fixes: 433fc58 ("VSOCK: Introduce vhost_vsock.ko") Cc: [email protected] Reported-by: Halil Pasic <[email protected]> Suggested-by: Jason Wang <[email protected]> Signed-off-by: Stefano Garzarella <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Halil Pasic <[email protected]>
1 parent f124034 commit 49d8c5f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/vhost/vsock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ static void vhost_vsock_handle_tx_kick(struct vhost_work *work)
554554
virtio_transport_free_pkt(pkt);
555555

556556
len += sizeof(pkt->hdr);
557-
vhost_add_used(vq, head, len);
557+
vhost_add_used(vq, head, 0);
558558
total_len += len;
559559
added = true;
560560
} while(likely(!vhost_exceeds_weight(vq, ++pkts, total_len)));

0 commit comments

Comments
 (0)