Skip to content

Commit 4a672d5

Browse files
linuswarndb
authored andcommitted
ARM: dts: Fix erroneous ADS touchscreen polarities
Several device tree files get the polarity of the pendown-gpios wrong: this signal is active low. Fix up all incorrect flags, so that operating systems can rely on the flag being correctly set. Signed-off-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnd Bergmann <[email protected]>
1 parent eeda0b7 commit 4a672d5

11 files changed

+11
-11
lines changed

arch/arm/boot/dts/am57xx-cl-som-am57x.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@
527527

528528
interrupt-parent = <&gpio1>;
529529
interrupts = <31 0>;
530-
pendown-gpio = <&gpio1 31 0>;
530+
pendown-gpio = <&gpio1 31 GPIO_ACTIVE_LOW>;
531531

532532

533533
ti,x-min = /bits/ 16 <0x0>;

arch/arm/boot/dts/at91sam9261ek.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
compatible = "ti,ads7843";
157157
interrupts-extended = <&pioC 2 IRQ_TYPE_EDGE_BOTH>;
158158
spi-max-frequency = <3000000>;
159-
pendown-gpio = <&pioC 2 GPIO_ACTIVE_HIGH>;
159+
pendown-gpio = <&pioC 2 GPIO_ACTIVE_LOW>;
160160

161161
ti,x-min = /bits/ 16 <150>;
162162
ti,x-max = /bits/ 16 <3830>;

arch/arm/boot/dts/imx7d-pico-hobbit.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
interrupt-parent = <&gpio2>;
6565
interrupts = <7 0>;
6666
spi-max-frequency = <1000000>;
67-
pendown-gpio = <&gpio2 7 0>;
67+
pendown-gpio = <&gpio2 7 GPIO_ACTIVE_LOW>;
6868
vcc-supply = <&reg_3p3v>;
6969
ti,x-min = /bits/ 16 <0>;
7070
ti,x-max = /bits/ 16 <4095>;

arch/arm/boot/dts/imx7d-sdb.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@
205205
pinctrl-0 = <&pinctrl_tsc2046_pendown>;
206206
interrupt-parent = <&gpio2>;
207207
interrupts = <29 0>;
208-
pendown-gpio = <&gpio2 29 GPIO_ACTIVE_HIGH>;
208+
pendown-gpio = <&gpio2 29 GPIO_ACTIVE_LOW>;
209209
touchscreen-max-pressure = <255>;
210210
wakeup-source;
211211
};

arch/arm/boot/dts/omap3-cm-t3x.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@
227227

228228
interrupt-parent = <&gpio2>;
229229
interrupts = <25 0>; /* gpio_57 */
230-
pendown-gpio = <&gpio2 25 GPIO_ACTIVE_HIGH>;
230+
pendown-gpio = <&gpio2 25 GPIO_ACTIVE_LOW>;
231231

232232
ti,x-min = /bits/ 16 <0x0>;
233233
ti,x-max = /bits/ 16 <0x0fff>;

arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454

5555
interrupt-parent = <&gpio1>;
5656
interrupts = <27 0>; /* gpio_27 */
57-
pendown-gpio = <&gpio1 27 GPIO_ACTIVE_HIGH>;
57+
pendown-gpio = <&gpio1 27 GPIO_ACTIVE_LOW>;
5858

5959
ti,x-min = /bits/ 16 <0x0>;
6060
ti,x-max = /bits/ 16 <0x0fff>;

arch/arm/boot/dts/omap3-lilly-a83x.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@
311311
interrupt-parent = <&gpio1>;
312312
interrupts = <8 0>; /* boot6 / gpio_8 */
313313
spi-max-frequency = <1000000>;
314-
pendown-gpio = <&gpio1 8 GPIO_ACTIVE_HIGH>;
314+
pendown-gpio = <&gpio1 8 GPIO_ACTIVE_LOW>;
315315
vcc-supply = <&reg_vcc3>;
316316
pinctrl-names = "default";
317317
pinctrl-0 = <&tsc2048_pins>;

arch/arm/boot/dts/omap3-overo-common-lcd35.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@
149149

150150
interrupt-parent = <&gpio4>;
151151
interrupts = <18 0>; /* gpio_114 */
152-
pendown-gpio = <&gpio4 18 GPIO_ACTIVE_HIGH>;
152+
pendown-gpio = <&gpio4 18 GPIO_ACTIVE_LOW>;
153153

154154
ti,x-min = /bits/ 16 <0x0>;
155155
ti,x-max = /bits/ 16 <0x0fff>;

arch/arm/boot/dts/omap3-overo-common-lcd43.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160

161161
interrupt-parent = <&gpio4>;
162162
interrupts = <18 0>; /* gpio_114 */
163-
pendown-gpio = <&gpio4 18 GPIO_ACTIVE_HIGH>;
163+
pendown-gpio = <&gpio4 18 GPIO_ACTIVE_LOW>;
164164

165165
ti,x-min = /bits/ 16 <0x0>;
166166
ti,x-max = /bits/ 16 <0x0fff>;

arch/arm/boot/dts/omap3-pandora-common.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@
651651
pinctrl-0 = <&penirq_pins>;
652652
interrupt-parent = <&gpio3>;
653653
interrupts = <30 IRQ_TYPE_NONE>; /* GPIO_94 */
654-
pendown-gpio = <&gpio3 30 GPIO_ACTIVE_HIGH>;
654+
pendown-gpio = <&gpio3 30 GPIO_ACTIVE_LOW>;
655655
vcc-supply = <&vaux4>;
656656

657657
ti,x-min = /bits/ 16 <0>;

0 commit comments

Comments
 (0)