Skip to content

Commit 4ac668a

Browse files
nbd168Kalle Valo
authored andcommitted
mt76: mt76x02: do not access uninitialized NAPI structs
Fixes a crash on MMIO devices when running into the watchdog reset Fixes: d3377b7 ("mt76: add HE phy modes and hardware queue") Signed-off-by: Felix Fietkau <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 6247c3b commit 4ac668a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,8 +456,9 @@ static void mt76x02_watchdog_reset(struct mt76x02_dev *dev)
456456
tasklet_disable(&dev->mt76.tx_tasklet);
457457
napi_disable(&dev->mt76.tx_napi);
458458

459-
for (i = 0; i < ARRAY_SIZE(dev->mt76.napi); i++)
459+
mt76_for_each_q_rx(&dev->mt76, i) {
460460
napi_disable(&dev->mt76.napi[i]);
461+
}
461462

462463
mutex_lock(&dev->mt76.mutex);
463464

@@ -515,7 +516,7 @@ static void mt76x02_watchdog_reset(struct mt76x02_dev *dev)
515516

516517
tasklet_enable(&dev->mt76.pre_tbtt_tasklet);
517518

518-
for (i = 0; i < ARRAY_SIZE(dev->mt76.napi); i++) {
519+
mt76_for_each_q_rx(&dev->mt76, i) {
519520
napi_enable(&dev->mt76.napi[i]);
520521
napi_schedule(&dev->mt76.napi[i]);
521522
}

0 commit comments

Comments
 (0)