Skip to content

Commit 4af5235

Browse files
KanjiMonsterPaolo Abeni
authored andcommitted
net: dsa: b53: do not enable RGMII delay on bcm63xx
bcm63xx's RGMII ports are always in MAC mode, never in PHY mode, so we shouldn't enable any delays and let the PHY handle any delays as necessary. This fixes using RGMII ports with normal PHYs like BCM54612E, which will handle the delay in the PHY. Fixes: ce3bf94 ("net: dsa: b53: add support for BCM63xx RGMIIs") Signed-off-by: Jonas Gorski <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent 1237c2d commit 4af5235

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,24 +1330,7 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch *ds, int port,
13301330
off = B53_RGMII_CTRL_P(port);
13311331

13321332
b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);
1333-
1334-
switch (interface) {
1335-
case PHY_INTERFACE_MODE_RGMII_ID:
1336-
rgmii_ctrl |= (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
1337-
break;
1338-
case PHY_INTERFACE_MODE_RGMII_RXID:
1339-
rgmii_ctrl &= ~(RGMII_CTRL_DLL_TXC);
1340-
rgmii_ctrl |= RGMII_CTRL_DLL_RXC;
1341-
break;
1342-
case PHY_INTERFACE_MODE_RGMII_TXID:
1343-
rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC);
1344-
rgmii_ctrl |= RGMII_CTRL_DLL_TXC;
1345-
break;
1346-
case PHY_INTERFACE_MODE_RGMII:
1347-
default:
1348-
rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
1349-
break;
1350-
}
1333+
rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
13511334

13521335
if (port != dev->imp_port) {
13531336
if (is63268(dev))

0 commit comments

Comments
 (0)