Skip to content

Commit 4affb57

Browse files
Philipp Hortmanngregkh
authored andcommitted
staging: rtl8723bs: Remove function pointer ReadEFuse
Remove function pointer ReadEFuse and use Hal_ReadEFuse directly to increase readability. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/92e249af89320d37a211397da7ccf82878359c60.1730749680.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent cd05890 commit 4affb57

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

drivers/staging/rtl8723bs/core/rtw_efuse.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ efuse_ReadEFuse(
159159
bool bPseudoTest
160160
)
161161
{
162-
Adapter->HalFunc.ReadEFuse(Adapter, efuseType, _offset, _size_byte, pbuf, bPseudoTest);
162+
Hal_ReadEFuse(Adapter, efuseType, _offset, _size_byte, pbuf, bPseudoTest);
163163
}
164164

165165
void

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,7 @@ static void hal_ReadEFuse_BT(
887887
kfree(efuseTbl);
888888
}
889889

890-
static void Hal_ReadEFuse(
890+
void Hal_ReadEFuse(
891891
struct adapter *padapter,
892892
u8 efuseType,
893893
u16 _offset,
@@ -1745,7 +1745,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
17451745
void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
17461746
{
17471747
/* Efuse related function */
1748-
pHalFunc->ReadEFuse = &Hal_ReadEFuse;
17491748
pHalFunc->EFUSEGetEfuseDefinition = &Hal_GetEfuseDefinition;
17501749
pHalFunc->EfuseGetCurrentSize = &Hal_EfuseGetCurrentSize;
17511750
pHalFunc->Efuse_PgPacketRead = &Hal_EfusePgPacketRead;

drivers/staging/rtl8723bs/include/hal_intf.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
164164
struct hal_ops {
165165
void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
166166

167-
void (*ReadEFuse)(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest);
168167
void (*EFUSEGetEfuseDefinition)(struct adapter *padapter, u8 efuseType, u8 type, void *pOut, bool bPseudoTest);
169168
u16 (*EfuseGetCurrentSize)(struct adapter *padapter, u8 efuseType, bool bPseudoTest);
170169
int (*Efuse_PgPacketRead)(struct adapter *padapter, u8 offset, u8 *data, bool bPseudoTest);
@@ -289,4 +288,6 @@ u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariabl
289288
void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level);
290289
void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter);
291290
void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
291+
void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset,
292+
u16 _size_byte, u8 *pbuf, bool bPseudoTest);
292293
#endif /* __HAL_INTF_H__ */

0 commit comments

Comments
 (0)